Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb-binlog: update kafka-max-message-size configuration #7201

Merged
merged 1 commit into from
Dec 14, 2021
Merged

tidb-binlog: update kafka-max-message-size configuration #7201

merged 1 commit into from
Dec 14, 2021

Conversation

shichun-0415
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

tidb-binlog: update kafka-max-message-size configuration

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 13, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hfxsd
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn December 13, 2021 11:44
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 13, 2021
@shichun-0415 shichun-0415 requested review from lichunzhu and hfxsd and removed request for TomShawn December 13, 2021 11:44
@shichun-0415 shichun-0415 added needs-cherry-pick-release-5.0 area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement. labels Dec 13, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Dec 13, 2021
lichunzhu
lichunzhu approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tidb-binlog/deploy-tidb-binlog.md Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 13, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 14, 2021
@hfxsd
Copy link
Collaborator

hfxsd commented Dec 14, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: df798c1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 14, 2021
@ti-chi-bot ti-chi-bot merged commit a741f2a into pingcap:master Dec 14, 2021
@shichun-0415 shichun-0415 deleted the tidb-binlog-update-kafka-max-message-size-configuration branch December 14, 2021 08:02
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 14, 2021
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7220.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 14, 2021
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7221.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 14, 2021
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7222.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7223.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 14, 2021
Merged
14 tasks
ti-chi-bot added a commit that referenced this pull request Dec 14, 2021
@ti-chi-bot
tidb-binlog: update kafka-max-message-size configuration (#7201) (#7221)
acd01dd
ti-chi-bot added a commit that referenced this pull request Dec 14, 2021
@ti-chi-bot
tidb-binlog: update kafka-max-message-size configuration (#7201) (#7220)
3201207
ti-chi-bot added a commit that referenced this pull request Dec 14, 2021
@ti-chi-bot
tidb-binlog: update kafka-max-message-size configuration (#7201) (#7223)
01f9a73
ti-chi-bot added a commit that referenced this pull request Dec 14, 2021
@ti-chi-bot
tidb-binlog: update kafka-max-message-size configuration (#7201) (#7222)
2c4b697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

Assignees
No one assigned
Labels
area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shichun-0415 @ti-chi-bot @hfxsd @lichunzhu